Skip to content

Add v1.24 for the CNPG library to keep backward compatibility. #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jakubhajek
Copy link
Contributor

Relates to: #540 (comment)

@adinhodovic
Copy link
Contributor

Relates to: #540 (comment)

Hmm the issue I describe is that I vendor a specific subdir to not have every version vendored.

    {
      "source": {
        "git": {
          "remote": "https://github.com/jsonnet-libs/cloudnative-pg-libsonnet.git",
          "subdir": "1.25.0"
        }
      },
      "version": "main"
    },

I'd like to keep every patch version for that minor. As soon as we bump and remove 1.25.0 to 1.25.1 and I run jb update I have issues now as the folder was deleted upstream. Do we really need to keep only a single patch version of every minor? Can't we keep all of them? And then delete them later on, rather where as of now we delete them all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants