Fix the confirmation Dialog box error #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue with the confirmation dialog box by ensuring the menu closes appropriately and adjusting the popover behavior.
- Added an immediate close on menu button click.
- Introduced explicit open/close delays and a conditional display style.
- Adjusted the reset action to close the menu after showing a toast notification.
Comments suppressed due to low confidence (1)
app/components/NavBarMenus/NavBarMenus.tsx:40
- [nitpick] Consider confirming that closing the menu immediately on button click (before sending the GA event) is the intended user experience, as it may affect the timing of event tracking.
setIsOpen(false);
JeelRajodiya
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Issue Number:
Screenshots/videos:
Screencast from 2025-04-29 22-29-17.webm
Summary
Resolve the unexpected behavior of the confirmation dialog box error. Now it is persistent and work properly.
Does this PR introduce a breaking change?
NO