Skip to content

Code quality refresh #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 56 commits into from
Sep 21, 2024

Use 'is' operator

7061e4c
Select commit
Loading
Failed to load commit list.
Merged

Code quality refresh #1609

Use 'is' operator
7061e4c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 21, 2024 in 1s

90.78% (-0.08%) compared to 4404e89

View this Pull Request on Codecov

90.78% (-0.08%) compared to 4404e89

Details

Codecov Report

Attention: Patch coverage is 90.06623% with 60 lines in your changes missing coverage. Please review.

Project coverage is 90.78%. Comparing base (4404e89) to head (7061e4c).

Files with missing lines Patch % Lines
...les/DapperExample/Repositories/DapperRepository.cs 30.00% 13 Missing and 1 partial ⚠️
...etCore/QueryStrings/FieldChains/MatchTraceScope.cs 12.50% 14 Missing ⚠️
...sonApiDotNetCore/Diagnostics/CascadingCodeTimer.cs 0.00% 4 Missing ⚠️
.../JsonApiDotNetCore/Middleware/JsonApiMiddleware.cs 78.94% 3 Missing and 1 partial ⚠️
src/JsonApiDotNetCore.Annotations/ArgumentGuard.cs 57.14% 1 Missing and 2 partials ⚠️
...c/JsonApiDotNetCore/Middleware/ExceptionHandler.cs 62.50% 3 Missing ⚠️
...ameworkExample/Services/InMemoryResourceService.cs 66.66% 0 Missing and 2 partials ⚠️
...onApiDotNetCore.Annotations/CollectionConverter.cs 66.66% 2 Missing ⚠️
...TranslationToSql/DataModel/BaseDataModelService.cs 66.66% 0 Missing and 1 partial ⚠️
...NetCore/Configuration/InverseNavigationResolver.cs 66.66% 0 Missing and 1 partial ⚠️
... and 12 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1609      +/-   ##
==========================================
- Coverage   90.85%   90.78%   -0.08%     
==========================================
  Files         348      349       +1     
  Lines       11189    11316     +127     
  Branches     1838     1849      +11     
==========================================
+ Hits        10166    10273     +107     
- Misses        672      681       +9     
- Partials      351      362      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov