Skip to content

Refactor Data properties in component schemas #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2024

Conversation

bkoelman
Copy link
Member

@bkoelman bkoelman commented Mar 30, 2024

This is required for adding atomic:operations support.

Using a Data base class is a leftover from an earlier JADNC version. Since then, we've changed serialization to use containment, so this PR adapts accordingly. The advantage is that we can now rely on the property declaration order, so we don't need to reorder ourselves like we used to.

QUALITY CHECKLIST

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.79%. Comparing base (1bdee8b) to head (10980e6).

Files Patch % Lines
...enApi/SwaggerComponents/DocumentSchemaGenerator.cs 75.00% 1 Missing and 1 partial ⚠️
...re.OpenApi/JsonApiRequestFormatMetadataProvider.cs 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           openapi    #1522      +/-   ##
===========================================
- Coverage    90.85%   90.79%   -0.07%     
===========================================
  Files          396      397       +1     
  Lines        13115    13023      -92     
  Branches      2078     2075       -3     
===========================================
- Hits         11916    11824      -92     
  Misses         781      781              
  Partials       418      418              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review March 30, 2024 08:38
@bkoelman bkoelman merged commit 1f38b99 into openapi Mar 30, 2024
16 checks passed
@bkoelman bkoelman deleted the refactor-data-properties branch March 30, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant