Skip to content

Conversation

@mash-graz
Copy link
Contributor

Fixes: #3640

@domenic
Copy link
Member

domenic commented Dec 23, 2023

This is missing tests. Fortunately, after 63265a9, you can probably follow the procedure outlined in https://github.com/jsdom/jsdom/blob/main/Contributing.md#web-platform-feature-tests to enable a preexisting test.

@mash-graz
Copy link
Contributor Author

mash-graz commented Dec 24, 2023

Although I could find already existing tests for getName in unmerged WPT branches, I can't simply enable them, because they are not available in the main branch of the WPT upstream repo or here in the test directory.

see:

web-platform-tests/wpt@a644106#diff-308a795609efdc52e2aee7ccd0ee171e4e1bd72a034183c807f81ee6dbdb0d61

web-platform-tests/wpt#39640

@asamuzaK
Copy link
Contributor

@asamuzaK asamuzaK mentioned this pull request Jan 11, 2025
@domenic domenic self-assigned this Aug 31, 2025
@domenic domenic merged commit d77ffd0 into jsdom:main Aug 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement customElements.getName()

3 participants