Skip to content

Conversation

@jquast
Copy link
Owner

@jquast jquast commented Nov 6, 2025

Improve sixel size order-preference by suggested implementation from @j4james,
pexpect/ptyprocess#79 (comment)

Pixel/Window and Sixel sizes are different because there is almost always some "remainder" in the margins of a window:
image

Sixel cannot draw in the black margin areas (smaller).

on-resize.py

The example script and surrounding documentation was improved to make this distinction clear, and, design tips on how "safely" use signal handlers as well as "de-bouncing" in our example.

Some example outputs of bin/on_resize.py:

  • Konsole height=29, width=143, pixel_height=764, pixel_width=1574, sixel_height=754, sixel_width=1573
  • Bobcat height=23, width=115, pixel_height=0, pixel_width=0, sixel_height=529, sixel_width=1150
  • kitty height=44, width=160, pixel_height=880, pixel_width=1440, sixel_height=0, sixel_width=0 (no sixel)
  • ghostty height=24, width=119, pixel_height=528, pixel_width=1190, sixel_height=0, sixel_width=0 (no sixel)

Implement sixel size preference by suggested implementation from,
pexpect/ptyprocess#79 (comment)
@jquast jquast marked this pull request as draft November 6, 2025 20:04
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.29%. Comparing base (496071b) to head (23d8d3f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #320   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files          11       11           
  Lines        2460     2470   +10     
  Branches      423      428    +5     
=======================================
+ Hits         2418     2428   +10     
  Misses         32       32           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jquast jquast marked this pull request as ready for review November 6, 2025 20:43
@jquast jquast changed the title Improved Sixel height and width size estimation Improved Sixel height and width, on_resize.py improved Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants