Add mention decorator for GitHub command handling #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuadavidthomas
had a problem deploying
to
integration
GitHub Actions
Failure
joshuadavidthomas
had a problem deploying
to
integration
GitHub Actions
Error
joshuadavidthomas
had a problem deploying
to
integration
GitHub Actions
Failure
Updates the kwarg passed to mention handlers from "mention" to "context" to better reflect that it contains a MentionContext object with comment, triggered_by, and scope fields. Also removes unused _mention_permission attribute from MentionHandlerBase protocol. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Moves the get_event_scope function to be a classmethod on MentionScope called from_event, following the same pattern as Comment.from_event. This provides a more consistent API and better encapsulation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add explicit kwargs to mention() decorator (pattern, username, scope) - Pass context as explicit parameter instead of mutating kwargs - Create MentionEvent.from_event() generator to encapsulate all mention processing logic (parsing, filtering, context creation) - Rename MentionContext to MentionEvent for clarity - Simplify router code from ~30 lines to 4 lines per wrapper This creates a much cleaner API where the mention decorator's wrappers simply iterate over MentionEvent instances yielded by the generator. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
joshuadavidthomas
force-pushed
the
gh-command
branch
from
f258928 to
aac1884
Compare
joshuadavidthomas
had a problem deploying
to
integration
GitHub Actions
Failure
joshuadavidthomas
temporarily deployed
to
integration
GitHub Actions
Inactive
joshuadavidthomas
had a problem deploying
to
integration
GitHub Actions
Failure
joshuadavidthomas
had a problem deploying
to
integration
GitHub Actions
Failure
joshuadavidthomas
had a problem deploying
to
integration
GitHub Actions
Failure
joshuadavidthomas
temporarily deployed
to
integration
GitHub Actions
Inactive
for more information, see https://pre-commit.ci
joshuadavidthomas
temporarily deployed
to
integration
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.