Skip to content

Skip too complex guards #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 11, 2024
Merged

Skip too complex guards #570

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f095cea
Add tests for (not) skipping complex guards
erszcz Sep 17, 2024
17e2770
Skip checking functions with too complex guards
erszcz Sep 11, 2024
0576b65
Refactor to avoid using an assertion
erszcz Sep 16, 2024
73e314f
Add type_refinement_should_fail.erl, fix type_refinement_fail.erl
erszcz Sep 17, 2024
ec5c19e
Drop unnecessary assertions
erszcz Sep 17, 2024
3f4fd6b
Run proptests on 25.1.2
erszcz Sep 17, 2024
8117a02
Run proptests on 26.2.5
erszcz Sep 17, 2024
701e244
Drop no_clause_has_guards condition when checking exhaustiveness
erszcz Sep 19, 2024
8858c41
Handle all erl_anno:file() cases, fix self-check error
erszcz Sep 20, 2024
c63080a
Export all tests from type_refinement_should_fail, fix specs
erszcz Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions test/known_problems/should_fail/type_refinement_should_fail.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
-module(type_refinement_should_fail).

-export([pattern_prevents_refinement/2]).

-spec guard_prevents_refinement(1..2, boolean()) -> 2.
guard_prevents_refinement(N, Guard) ->
case N of
1 when Guard -> 2;
M -> M %% 1 cannot be eliminated
end.

-spec guard_prevents_refinement2(erlang:timestamp()) -> ok.
guard_prevents_refinement2(X) when is_integer(X), X rem 7 == 0 -> ok;
guard_prevents_refinement2(infinity) -> ok. % can still be an integer

-spec pattern_prevents_refinement(erlang:timestamp(), any()) -> atom().
pattern_prevents_refinement(X, X) when is_integer(X) -> ok;
pattern_prevents_refinement(X, {_Y}) when is_integer(X) -> ok;
pattern_prevents_refinement(Inf, _) -> Inf. % Inf can still be an integer
21 changes: 2 additions & 19 deletions test/should_fail/type_refinement_fail.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,7 @@
-module(type_refinement_fail).
-export([guard_prevents_refinement/2, imprecision_prevents_refinement/2,
multi_pat_fail_1/2,
guard_prevents_refinement2/1,
pattern_prevents_refinement/2]).

-spec guard_prevents_refinement(1..2, boolean()) -> 2.
guard_prevents_refinement(N, Guard) ->
case N of
1 when Guard -> 2;
M -> M %% 1 cannot be eliminated
end.
-export([imprecision_prevents_refinement/2,
multi_pat_fail_1/2]).

-spec imprecision_prevents_refinement(float(), a|b) -> b.
imprecision_prevents_refinement(3.14, a) -> b;
Expand All @@ -18,12 +10,3 @@ imprecision_prevents_refinement(_, X) -> X.
-spec multi_pat_fail_1(a|b, a|b) -> {b, b}.
multi_pat_fail_1(a, a) -> {b, b};
multi_pat_fail_1(A, B) -> {A, B}. %% Not only {b, b} here

-spec guard_prevents_refinement2(erlang:timestamp()) -> ok.
guard_prevents_refinement2(X) when is_integer(X), X rem 7 == 0 -> ok;
guard_prevents_refinement2(infinity) -> ok. % can still be an integer

-spec pattern_prevents_refinement(erlang:timestamp(), any()) -> atom().
pattern_prevents_refinement(X, X) when is_integer(X) -> ok;
pattern_prevents_refinement(X, {_Y}) when is_integer(X) -> ok;
pattern_prevents_refinement(Inf, _) -> Inf. % Inf can still be an integer