Fix presentation issue #702
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the view of the presenting view controller to the transition container view causes an accessibility issue when using the keyboard option. Typical iOS behavior is that a view controller that was presented on top of another view controller will take all the keyboard gestures and that the view under will not be accessible with the keyboard. The issue here is that by adding the presenting view to the container iOS now will make it on the same level as the presented view with respect to accessibility. In order to support the change we remove the presenting view from the container, this poses an issue because the presentation style contains a background which now doesn't make much sense to have as it is rendered above the presenting view, so we also remove the option to set a custom background color.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the view of the presenting view controller to the transition container view causes an accessibility issue when using the keyboard option. Typical iOS behavior is that a view controller that was presented on top of another view controller will take all the keyboard gestures and that the view under will not be accessible with the keyboard.
The issue here is that by adding the presenting view to the container iOS now will make it on the same level as the presented view with respect to accessibility.
In order to support the change we remove the presenting view from the container, this poses an issue because the presentation style contains a background which now doesn't make much sense to have as it is rendered above the presenting view, so we also remove the option to set a custom background color.