-
Notifications
You must be signed in to change notification settings - Fork 145
xctrace support
#286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xctrace support
#286
Conversation
8988028 to
4fdfd61
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
- Coverage 91.38% 90.68% -0.70%
==========================================
Files 20 21 +1
Lines 4444 4725 +281
==========================================
+ Hits 4061 4285 +224
- Misses 383 440 +57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4fdfd61 to
959928b
Compare
|
Hey, I was going to start working on integrating this only to see the work was already done! Thanks @ldm0! I can help add the documentation if needed. Also not sure if this feature need to be tied to the |
Thanks! I've written some documentation already, will submit it tomorrow. I think introducing multiple versions of the same dependency is bad(in terms of artifact size and complexity), so I'm waiting for the BTW, I've forked |
959928b to
49ff175
Compare
41bad5a to
fa5ffda
Compare
fa5ffda to
fef528b
Compare
|
Same, I've been using it locally without issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's exciting, thanks! Took a first pass now. Nothing too deep to change, though some stuff that'll make this easier to maintain longer-term :)
3af45ef to
dde90c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, it's already looking a lot better, thank you!
|
ping @jonhoo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about that taking forever! Looks good to me now — let's get this landed and released! 🎉
|
Releasing as 0.12.2 in #340 |
|
Thanks for reviewing this! |
|
No, thank you for sticking with it for so long! |
Basically working. Required to be done:quick-xmlupdate Bump quick-xml to 0.37.0 and remove it from public APIs #332Fixes #246
xctraceis a tracer used internally by Apple Instruments. It generates a.tracefolder containing a bunch of files in an unknown binary format. People have reverse engineerd it but it's internal format changed after XCode 12.There's a
xctrace exportcommand, which can convert.traceinto a readable XML file. However, it's output can't be used to generate flamegraphs until XCode 14.3, which introduces VM address and symbol name to the XML output.In this PR, I added a stack collapser for XML files generated by
xctrace export, making it possible to convertInstrumentsorxctrace‘s output into flamegraph.