-
Notifications
You must be signed in to change notification settings - Fork 13
Rework add-ons and integrate troubleshoot file transfer feature #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31281ff
to
4d5942e
Compare
1f106db
to
a17c507
Compare
a17c507
to
55c0032
Compare
27ad2c6
to
ebc7226
Compare
…cture to add file transfer
ebc7226
to
843d677
Compare
|
Tested on ESP32 and Zephyr examples with files up to 60KB, both upload and download, will now merge the feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this Pull-Request is to rework add-ons architecture to integrate new troubleshoot feature such as the fiel transfer APIs. See #80.
Add-ons APIs have been moved to add-ns directory so that the core APIs doesn't include add-ons APIs.
Troubleshoot add-on is totally reworked. Troubleshoot callbacks are modified.