Add OSGi metadata to jnr-x86asm. #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use maven-bundle-plugin to generate OSGi metadata and include the manifest using maven-jar-plugin.
|
This works great for me, would really appreciate it if it was merged in 👍 |
|
Any chance of getting a release with this change? Thanks! |
|
Bump. Would be nice to see this merged and released to Maven 👍 |
|
This seems fine, but maybe my friend @mkristian can do a quick review? This has sat dormant for some time. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use maven-bundle-plugin to generate OSGi metadata and include the
manifest using maven-jar-plugin.
This change only adds additional entries to the MANIFEST.MF shipped in the final jar artifact. The attributes would not affect current consumers of this artifact.