Skip to content

internal: add types to base-core #29513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2025
Merged

Conversation

mshima
Copy link
Member

@mshima mshima commented May 17, 2025

  • remove custom angularEntities from angular.
    • convert usage to needles
  • add generic support to base-core
    • jhipsterConfig
    • jhipsterConfigWithDefaults

Related to #28235


Please make sure the below checklist is followed for Pull Requests.

When you are still working on the PR, consider converting it to Draft (below reviewers) and adding skip-ci label, you can still see CI build result at your branch.

@Tcharl
Copy link
Contributor

Tcharl commented May 18, 2025

Hi,

Would it be possible to work on the same branch for the types? #29437.
The result will be quicker to reach and will prevent conflicts

@mshima
Copy link
Member Author

mshima commented May 18, 2025

Hi,

Would it be possible to work on the same branch for the types? #29437. The result will be quicker to reach and will prevent conflicts

  • that branch is failing to build
  • control will not be generic.
  • SharedData class will not be generic. It will be removed.

Once base-core is complete, application related types can be worked at once.

@mshima mshima marked this pull request as ready for review May 18, 2025 20:02
@mshima mshima force-pushed the config-types branch 2 times, most recently from fa59cc0 to 4384167 Compare May 19, 2025 10:57
@DanielFran DanielFran merged commit 8f6be15 into jhipster:main May 20, 2025
67 checks passed
@mshima mshima deleted the config-types branch May 20, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants