Skip to content

Add types on generator-cicd #28427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+744 −114
Open

Add types on generator-cicd #28427

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fc63b07
rewamp types on generator-cicd
Tcharl Jan 8, 2025
db8f835
update snapshots
Tcharl Jan 8, 2025
aaee1f9
Merge branch 'main' into cicd-types
Tcharl May 8, 2025
5048cde
updating snapshots
Tcharl May 8, 2025
5bceb1c
Update generators/ci-cd/generator.spec.ts
Tcharl May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 81 additions & 0 deletions generators/app/__snapshots__/generator.spec.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,10 @@ exports[`generator - app with default config should match snapshot 1`] = `
"applicationTypeGateway": false,
"applicationTypeMicroservice": false,
"applicationTypeMonolith": true,
"artifactoryReleasesId": undefined,
"artifactoryReleasesUrl": undefined,
"artifactorySnapshotsId": undefined,
"artifactorySnapshotsUrl": undefined,
"authenticationType": "jwt",
"authenticationTypeAny": true,
"authenticationTypeJwt": true,
Expand Down Expand Up @@ -255,6 +259,22 @@ exports[`generator - app with default config should match snapshot 1`] = `
"camelizedBaseName": "jhipster",
"capitalizedBaseName": "Jhipster",
"caret": undefined,
"ciCd": undefined,
"ciCdAny": false,
"ciCdAzure": false,
"ciCdCircle": false,
"ciCdGithub": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should Hub be capitalized like it is in GitHub?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was like this previously, didn't changed anything here

"ciCdGitlab": false,
"ciCdIntegrations": undefined,
"ciCdIntegrationsAny": false,
"ciCdIntegrationsCypressDashboard": false,
"ciCdIntegrationsDeploy": false,
"ciCdIntegrationsHeroku": false,
"ciCdIntegrationsPublishDocker": false,
"ciCdIntegrationsSnyk": false,
"ciCdIntegrationsSonar": false,
"ciCdJenkins": false,
"ciCdTravis": false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is Travis still being used by developers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use it personally: the only CI provider that offer Vt-x machines (for nested virt). Still, it was here before, I just changed the code approach to fit with current best practices

"cjsExtension": ".js",
"cliName": undefined,
"clientBundler": "webpack",
Expand Down Expand Up @@ -451,6 +471,7 @@ exports[`generator - app with default config should match snapshot 1`] = `
"zipkinImage": "zipkin-image-placeholder",
"zipkinTag": "zipkin-tag-placeholder",
},
"dockerImage": undefined,
"dockerServices": [
"app",
"postgresql",
Expand Down Expand Up @@ -490,6 +511,7 @@ exports[`generator - app with default config should match snapshot 1`] = `
"githubWorkflows": undefined,
"graalvmSupport": undefined,
"gradleEnterpriseHost": undefined,
"herokuAppName": undefined,
"hipster": "jhipster_family_member_3",
"hipsterBugTrackerLink": "https://github.com/jhipster/generator-jhipster/issues?state=open",
"hipsterBugTrackerProductName": "JHipster",
Expand All @@ -507,6 +529,7 @@ exports[`generator - app with default config should match snapshot 1`] = `
"humanizedBaseName": "JHipster",
"imperativeOrReactive": "imperative",
"incrementalChangelog": undefined,
"insideDocker": undefined,
"javaCompatibleVersions": [
"17",
"21",
Expand Down Expand Up @@ -817,6 +840,7 @@ exports[`generator - app with default config should match snapshot 1`] = `
"searchEngineCouchbase": false,
"searchEngineElasticsearch": false,
"searchEngineNo": true,
"sendBuildToGitlab": undefined,
"serverPort": 8080,
"serviceDiscovery": "no",
"serviceDiscoveryAny": false,
Expand All @@ -835,6 +859,9 @@ exports[`generator - app with default config should match snapshot 1`] = `
"skipJhipsterDependencies": undefined,
"skipServer": undefined,
"skipUserManagement": false,
"sonarName": undefined,
"sonarOrga": undefined,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be sonarOrg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was like this previously, didn't changed anything here

"sonarUrl": undefined,
"springBootDependencies": Any<Object>,
"srcMainDir": "src/main/",
"srcMainJava": "src/main/java/",
Expand Down Expand Up @@ -895,6 +922,10 @@ exports[`generator - app with gateway should match snapshot 1`] = `
"applicationTypeGateway": true,
"applicationTypeMicroservice": false,
"applicationTypeMonolith": false,
"artifactoryReleasesId": undefined,
"artifactoryReleasesUrl": undefined,
"artifactorySnapshotsId": undefined,
"artifactorySnapshotsUrl": undefined,
"authenticationType": "jwt",
"authenticationTypeAny": true,
"authenticationTypeJwt": true,
Expand Down Expand Up @@ -924,6 +955,22 @@ exports[`generator - app with gateway should match snapshot 1`] = `
"camelizedBaseName": "jhipster",
"capitalizedBaseName": "Jhipster",
"caret": undefined,
"ciCd": undefined,
"ciCdAny": false,
"ciCdAzure": false,
"ciCdCircle": false,
"ciCdGithub": false,
"ciCdGitlab": false,
"ciCdIntegrations": undefined,
"ciCdIntegrationsAny": false,
"ciCdIntegrationsCypressDashboard": false,
"ciCdIntegrationsDeploy": false,
"ciCdIntegrationsHeroku": false,
"ciCdIntegrationsPublishDocker": false,
"ciCdIntegrationsSnyk": false,
"ciCdIntegrationsSonar": false,
"ciCdJenkins": false,
"ciCdTravis": false,
"cjsExtension": ".js",
"cliName": undefined,
"clientBundler": "webpack",
Expand Down Expand Up @@ -1120,6 +1167,7 @@ exports[`generator - app with gateway should match snapshot 1`] = `
"zipkinImage": "zipkin-image-placeholder",
"zipkinTag": "zipkin-tag-placeholder",
},
"dockerImage": undefined,
"dockerServices": [
"app",
"consul",
Expand Down Expand Up @@ -1161,6 +1209,7 @@ exports[`generator - app with gateway should match snapshot 1`] = `
"githubWorkflows": undefined,
"graalvmSupport": undefined,
"gradleEnterpriseHost": undefined,
"herokuAppName": undefined,
"hipster": "jhipster_family_member_3",
"hipsterBugTrackerLink": "https://github.com/jhipster/generator-jhipster/issues?state=open",
"hipsterBugTrackerProductName": "JHipster",
Expand All @@ -1178,6 +1227,7 @@ exports[`generator - app with gateway should match snapshot 1`] = `
"humanizedBaseName": "JHipster",
"imperativeOrReactive": "reactive",
"incrementalChangelog": undefined,
"insideDocker": undefined,
"javaCompatibleVersions": [
"17",
"21",
Expand Down Expand Up @@ -1483,6 +1533,7 @@ exports[`generator - app with gateway should match snapshot 1`] = `
"searchEngineCouchbase": false,
"searchEngineElasticsearch": false,
"searchEngineNo": true,
"sendBuildToGitlab": undefined,
"serverPort": 8080,
"serviceDiscovery": "consul",
"serviceDiscoveryAny": true,
Expand All @@ -1501,6 +1552,9 @@ exports[`generator - app with gateway should match snapshot 1`] = `
"skipJhipsterDependencies": undefined,
"skipServer": undefined,
"skipUserManagement": false,
"sonarName": undefined,
"sonarOrga": undefined,
"sonarUrl": undefined,
"springBootDependencies": Any<Object>,
"srcMainDir": "src/main/",
"srcMainJava": "src/main/java/",
Expand Down Expand Up @@ -1559,6 +1613,10 @@ exports[`generator - app with microservice should match snapshot 1`] = `
"applicationTypeGateway": false,
"applicationTypeMicroservice": true,
"applicationTypeMonolith": false,
"artifactoryReleasesId": undefined,
"artifactoryReleasesUrl": undefined,
"artifactorySnapshotsId": undefined,
"artifactorySnapshotsUrl": undefined,
"authenticationType": "jwt",
"authenticationTypeAny": true,
"authenticationTypeJwt": true,
Expand Down Expand Up @@ -1587,6 +1645,22 @@ exports[`generator - app with microservice should match snapshot 1`] = `
"camelizedBaseName": "jhipster",
"capitalizedBaseName": "Jhipster",
"caret": undefined,
"ciCd": undefined,
"ciCdAny": false,
"ciCdAzure": false,
"ciCdCircle": false,
"ciCdGithub": false,
"ciCdGitlab": false,
"ciCdIntegrations": undefined,
"ciCdIntegrationsAny": false,
"ciCdIntegrationsCypressDashboard": false,
"ciCdIntegrationsDeploy": false,
"ciCdIntegrationsHeroku": false,
"ciCdIntegrationsPublishDocker": false,
"ciCdIntegrationsSnyk": false,
"ciCdIntegrationsSonar": false,
"ciCdJenkins": false,
"ciCdTravis": false,
"cjsExtension": ".js",
"cliName": undefined,
"clientBundler": undefined,
Expand Down Expand Up @@ -1783,6 +1857,7 @@ exports[`generator - app with microservice should match snapshot 1`] = `
"zipkinImage": "zipkin-image-placeholder",
"zipkinTag": "zipkin-tag-placeholder",
},
"dockerImage": undefined,
"dockerServices": [
"app",
"consul",
Expand Down Expand Up @@ -1824,6 +1899,7 @@ exports[`generator - app with microservice should match snapshot 1`] = `
"githubWorkflows": undefined,
"graalvmSupport": undefined,
"gradleEnterpriseHost": undefined,
"herokuAppName": undefined,
"hipster": "jhipster_family_member_3",
"hipsterBugTrackerLink": "https://github.com/jhipster/generator-jhipster/issues?state=open",
"hipsterBugTrackerProductName": "JHipster",
Expand All @@ -1841,6 +1917,7 @@ exports[`generator - app with microservice should match snapshot 1`] = `
"humanizedBaseName": "JHipster",
"imperativeOrReactive": "imperative",
"incrementalChangelog": undefined,
"insideDocker": undefined,
"javaCompatibleVersions": [
"17",
"21",
Expand Down Expand Up @@ -2079,6 +2156,7 @@ exports[`generator - app with microservice should match snapshot 1`] = `
"searchEngineCouchbase": false,
"searchEngineElasticsearch": false,
"searchEngineNo": true,
"sendBuildToGitlab": undefined,
"serverPort": 8081,
"serviceDiscovery": "consul",
"serviceDiscoveryAny": true,
Expand All @@ -2097,6 +2175,9 @@ exports[`generator - app with microservice should match snapshot 1`] = `
"skipJhipsterDependencies": undefined,
"skipServer": undefined,
"skipUserManagement": true,
"sonarName": undefined,
"sonarOrga": undefined,
"sonarUrl": undefined,
"springBootDependencies": Any<Object>,
"srcMainDir": "src/main/",
"srcMainJava": "src/main/java/",
Expand Down
26 changes: 26 additions & 0 deletions generators/bootstrap-application-client/types-partials.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
/**
* Copyright 2013-2025 the original author or authors from the JHipster project.
*
* This file is part of the JHipster project, see https://www.jhipster.tech/
* for more information.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
/**
* @deprecated will be deprecated in favor of a generator-dedicated class, every attribute will be moved there then.
*/
export type PartialApplicationBootstrapApplicationClient = {
clientBundlerWebpack?: boolean;
clientBundlerExperimentalEsbuild?: boolean;
clientBundlerVite?: boolean;
};
Loading
Loading