Stop profiling in forked child process #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
reviewed
Jul 23, 2024
Otherwise the child will hang forever on exit when trying to dump the profiling data. Which is problematic when trying to profile some programs. There might be more elegant ways to handle it, this is mostly a proof of concept. Also it's not quite fully working, the test passes alone, but but if ran after some other specific tests, it end up in a SIGTRAP, which I'm not sure why: ``` bundle exec rake SEED=26641 TESTOPTS="-v" ... 1) Failure: TestVernier#test_that_forked_children_do_not_hang [test/test_vernier.rb:15]: Expected #<Process::Status: pid 63146 SIGTRAP (signal 5)> to be success?. ```
casperisfine
force-pushed
the
fork-compat
branch
from
4196e11 to
14c8e90
Compare
haiderRizvii
approved these changes
Sep 9, 2024
joshuay03
force-pushed
the
main
branch
2 times, most recently
from
6f1d6a6 to
757871e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the child will hang forever on exit when trying to dump the profiling data. Which is problematic when trying to profile some programs.
There might be more elegant ways to handle it, this is mostly a proof of concept.
Also it's not quite fully working, the test passes alone, but but if ran after some other specific tests, it end up in a SIGTRAP, which I'm not sure why:
cc @tenderlove @jhawthorn