Skip to content

Conversation

arkirchner
Copy link
Contributor

When a Rails Engines *_rfc6570 method is called from the main app, the argument will be a hash. *_rfc6570 needs to support both keyword arguments and a hash argument.

Copy link

codecov bot commented Sep 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3e31da2) to head (aff065e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          161       161           
=========================================
  Hits           161       161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

When a Rails Engines `*_rfc6570` method is called from the main app,
the argument will be a hash. `*_rfc6570` needs to support both
keyword arguments and a hash argument.
@arkirchner
Copy link
Contributor Author

Sorry for not getting back to you about this in the last PR. Only now I realized that this issue is present when calling the template from a Rails engine from the main app.

We are moving services into engines to fold them into the main app. We are using Draper decorators that have an application controller passed in from the main app. Engine decorators call URLs through the main app's routes.

module SomeEngine
  class ApplicationDecorator < Draper::Decorator
    # Draper will use the main apps helper by default.
    def h
      super.some_engine
    end
  end
end

@jgraichen
Copy link
Owner

Thanks!

@jgraichen jgraichen self-assigned this Sep 28, 2025
@jgraichen jgraichen merged commit 3aa1e74 into jgraichen:main Sep 28, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants