Support mounted Rails Engines #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RFC6570 path-only code previously skipped the Rails URL generation backend but only returned the template path. This resulted in skipping the prefix from mounted engines. This commit changes the code to always use `ActionDispatch::Http::URL.url_for` for all URL generation after expanding the template and to pass `only_path` as an option when need. This way, full URL and path only generation behaves identical and both will include the correct rails mount paths.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 162 161 -1
=========================================
- Hits 162 161 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #42 because GitHub failed to accept pushes to editable PR branches.
The RFC6570 path-only code previously skipped the Rails URL generation backend but only returned the template path. This resulted in skipping the prefix from mounted engines.
The PR changes the code to always use
ActionDispatch::Http::URL.url_forfor all URL generation after expanding the template and to passonly_pathas an option when needed. This way, full URL and path-only generation behave identically, and both will include the correct Rails mount paths now.