fix: Optimize route generation in rfc6570_route/s helper #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The #rfc6570_routes helper directly delegates to #to_rfc6570 on the named routes collection now, avoiding manual iteration and an extra lookup via #rfc6570_route. Otherwise, both methods the context-local #_routes method now, instead of Rails.application.routes, which eases testing. New helper specs verify both method in detail now too.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
+ Coverage 98.78% 99.38% +0.59%
==========================================
Files 4 4
Lines 165 162 -3
==========================================
- Hits 163 161 -2
+ Misses 2 1 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
#rfc6570_routeshelper directly delegates to#to_rfc6570on the named routes collection now, avoiding manual iteration and an extra lookup via#rfc6570_route(name).Otherwise, both methods the context-local
#_routesmethod now, instead ofRails.application.routes, which eases testing. New helper specs verify both method in detail.