fix: Invalid args on RouteSet#to_rfc6570 #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two semi-public methods RouteSet#to_rfc6570 and NamedRouteCollection#to_rfc6570 were using the old, no longer working, kwargs format. Both methods are working again. RouteSet#to_rfc6570 has been adjusted to return a hash with named routes only, since the array before isn't much useful, and it was broken. New specs explicitly test RouteSet#to_rfc6570, and, by indirection, NamedRouteCollection#to_rfc6570.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
+ Coverage 96.96% 98.78% +1.81%
==========================================
Files 4 4
Lines 165 165
==========================================
+ Hits 160 163 +3
+ Misses 5 2 -3 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two semi-public methods
RouteSet#to_rfc6570andNamedRouteCollection#to_rfc6570were using the old, no longer working, kwargs format. Both methods are working again.RouteSet#to_rfc6570has been adjusted to return a hash with named routes only, since the array before isn't much useful, and it was broken.New specs explicitly test
RouteSet#to_rfc6570, and, by indirection,NamedRouteCollection#to_rfc6570.