Skip to content

[Release 1.0.0 part 1] bump helm chart to version to 1.0.0 and appVersion to v1.0.0 #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

maelvls
Copy link
Member

@maelvls maelvls commented Sep 3, 2024

This commit belongs to the release process for v1.0.0.

I've removed an instruction from the release process as I've noticed that the tag is now commented out in the values.yaml file:

image:
  # -- Overrides the image tag whose default is the chart appVersion
  # tag: "v0.0.0"

Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

$ helm package deploy/charts/venafi-kubernetes-agent/
Successfully packaged chart and saved it to: /home/richard/projects/venafi/venafi-kubernetes-agent/venafi-kubernetes-agent-1.0.0.tgz

$ helm inspect chart venafi-kubernetes-agent-1.0.0.tgz
apiVersion: v2
appVersion: v1.0.0
description: The Venafi Kubernetes Agent connects your Kubernetes or Openshift cluster
  to the Venafi Control Plane.
name: venafi-kubernetes-agent
type: application
version: 1.0.0

$ helm template venafi-kubernetes-agent-1.0.0.tgz  | grep -C5 "image:"
            capabilities:
              drop:
              - ALL
            readOnlyRootFilesystem: true
            runAsNonRoot: true
          image: "registry.venafi.cloud/venafi-agent/venafi-agent:v1.0.0"
          imagePullPolicy: IfNotPresent
          args:
            - "agent"
            - "-c"
            - "/etc/venafi/agent/config/config.yaml"

@wallrj
Copy link
Member

wallrj commented Sep 3, 2024

I had to double check that the Docker image URL was correct, because it's venafi-agent rather than venafi-kubernetes-agent.
In future, we ought to update the Docker image name for consistency:

@maelvls
Copy link
Member Author

maelvls commented Sep 3, 2024

Thanks for testing the Helm chart. I forgot to do that before opening this PR...

@maelvls maelvls merged commit 2119b80 into master Sep 3, 2024
8 checks passed
@maelvls
Copy link
Member Author

maelvls commented Sep 3, 2024

I've continued the release process but got stuck at:

$ helm push venafi-kubernetes-agent-${VERSION}.tgz oci://eu.gcr.io/jetstack-secure-enterprise/charts
Successfully packaged chart and saved it to: /Users/mvalais/code/jetstack/jetstack-secure/venafi-kubernetes-agent-1.0.0.tgz
Error: failed to authorize: failed to fetch oauth token: unexpected status from GET request to https://eu.gcr.io/v2/token?scope=repository%3Ajetstack-secure-enterprise%2Fcharts%2Fvenafi-kubernetes-agent%3Apull&scope=repository%3Ajetstack-secure-enterprise%2Fcharts%2Fvenafi-kubernetes-agent%3Apull%2Cpush&service=eu.gcr.io: 403 Forbidden

I've noticed that I'm an owner of the jetstack-secure-enterprise project, so I should be able to push this OCI Helm chart...

Have you ever seen this? @wallrj

Update: I think I forgot to re-login using docker login.

@maelvls maelvls changed the title Helm: bump version to 1.0.0 and appVersion to v1.0.0 [Release 1.0.0] bump helm chart to version to 1.0.0 and appVersion to v1.0.0 Sep 3, 2024
@maelvls
Copy link
Member Author

maelvls commented Sep 3, 2024

I was able to push the OCI helm chart, but first I had to run:

docker login -u oauth2accesstoken --password-stdin eu.gcr.io < <(gcloud auth application-default print-access-token)

I'll add that to the release instructions.

@maelvls maelvls deleted the release-1.0.0 branch September 3, 2024 12:18
@maelvls maelvls changed the title [Release 1.0.0] bump helm chart to version to 1.0.0 and appVersion to v1.0.0 [Release 1.0.0 part 1] bump helm chart to version to 1.0.0 and appVersion to v1.0.0 Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants