Skip to content

feat(httpproxy): Update chart to support httproxy #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deploy/charts/venafi-kubernetes-agent/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@ name: venafi-kubernetes-agent
description: |-
The Venafi Kubernetes Agent connects your Kubernetes or Openshift cluster to the Venafi Control Plane.
type: application
version: 0.1.46
appVersion: "v0.1.46"
version: 0.1.47
appVersion: "v0.1.47"
19 changes: 13 additions & 6 deletions deploy/charts/venafi-kubernetes-agent/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,20 @@ spec:
{{- toYaml .Values.securityContext | nindent 12 }}
image: "{{ .Values.image.repository }}:{{ .Values.image.tag | default .Chart.AppVersion }}"
imagePullPolicy: {{ .Values.image.pullPolicy }}
{{- if eq .Values.authentication.type "token" }}
{{- if or .Values.http_proxy .Values.https_proxy .Values.no_proxy }}
env:
- name: API_TOKEN
valueFrom:
secretKeyRef:
name: {{ default "agent-credentials" .Values.authentication.secretName }}
key: {{ default "apitoken" .Values.authentication.secretKey }}
{{- with .Values.http_proxy }}
- name: HTTP_PROXY
value: {{ . }}
{{- end }}
{{- with .Values.https_proxy }}
- name: HTTPS_PROXY
value: {{ . }}
{{- end }}
{{- with .Values.no_proxy }}
- name: NO_PROXY
value: {{ . }}
{{- end }}
{{- end }}
{{- if not (empty .Values.command) }}
command:
Expand Down
17 changes: 16 additions & 1 deletion deploy/charts/venafi-kubernetes-agent/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ image:
# -- Defaults to only pull if not already present
pullPolicy: IfNotPresent
# -- Overrides the image tag whose default is the chart appVersion
tag: "v0.1.45"
tag: "v0.1.47"

# -- Specify image pull credentials if using a private registry
# example: - name: my-pull-secret
Expand Down Expand Up @@ -41,6 +41,21 @@ podSecurityContext: {}
# runAsGroup: 3000
# fsGroup: 2000

# Use these variables to configure the HTTP_PROXY environment variables.

# Configures the HTTP_PROXY environment variable where a HTTP proxy is required.
# +docs:property
# http_proxy: "http://proxy:8080"

# Configures the HTTPS_PROXY environment variable where a HTTP proxy is required.
# +docs:property
# https_proxy: "https://proxy:8080"

# Configures the NO_PROXY environment variable where a HTTP proxy is required,
# but certain domains should be excluded.
# +docs:property
# no_proxy: 127.0.0.1,localhost

# -- Add Container specific SecurityContext settings to the container. Takes precedence over `podSecurityContext` when set. See https://kubernetes.io/docs/tasks/configure-pod-container/security-context/#set-capabilities-for-a-container
securityContext:
capabilities:
Expand Down