Add --envrc-dir flag to allow specifying location of direnv config #2629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2459 - devbox generate direnv does not respect --config
It seems that the previous mode of operation for
devbox generate direnv --config <some-dir>
used--config
to determine the location of the resulting.envrc
file, rather than as the location of thedevbox.json
file. But in some cases it is desired to be able to specify not only the location of not only the direnv.envrc
file, but also the devbox config file. Or at least to be able to specify just the location of the devbox config with the.envrc
being in the current directory.To accomplish this, without breaking the current mode of operation, a new parameter is added,
--envrc-dir
, which specifies the location of the resulting.envrc
file. For example, the commanddevbox generate direnv --envrc-dir ABC --config ABC/XYZ
would createABC/.envrc
and within that would be the commandeval "$(devbox generate direnv --print-envrc --config XYZ)"
Without the new
--envrc-dir
param, operation is the same as it was previously, even with the--config
(which will be used to specify the location of the.envrc
file, NOT the devbox config file,devbox.json
.How was it tested?
Several new tests have been created to cover cases with and without the new
--envrc-dir
param.Community Contribution License
All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.