Improve persistance of images and add stats #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve image persistence and extend session statistics tracking.
- Adds new session statistic fields for photos and intel in the stats view and related services.
- Removes the expiration check when restoring images to improve image persistence.
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cTabIRL/cTabWebApp/Views/Home/Stats.cshtml | Adds new statistics entries for ActiveSessionsWithPhotos and ActiveSessionsWithIntel. |
| cTabIRL/cTabWebApp/Services/PlayerStateServiceStats.cs | Introduces new properties for Intel and Photos sessions. |
| cTabIRL/cTabWebApp/Services/PlayerStateService.cs | Updates statistic calculations to include photo and intel session counts. |
| cTabIRL/cTabWebApp/Services/Images/ImageService.cs | Modifies image restoration by omitting the expiration check. |
Files not reviewed (2)
- cTabIRL/setup/appsettings.Production.json: Language not supported
- cTabIRL/setup/setup.sh: Language not supported
Comments suppressed due to low confidence (1)
cTabIRL/cTabWebApp/Services/Images/ImageService.cs:59
- Removing the expiration check may lead to restoring expired images; please verify if this behavior is intended or if the condition should be reincluded to prevent stale image data from being added.
if (entry != null && entry.Token == token)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.