Show [0] keybinding in main view title #4754
Open
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not a behavior change, we already include these in the menu, but that's because of a bug that we will fix in the next commit. I find it useful to see these commands, especially for rarely-used custom commands that you don't want to waste a keybinding on.
It previously returned "\x00", which is probably not intended, but happened to work.
I left this out originally because it's not needed for the status "dashboard" view (except on really tiny screens); however, it *is* useful after pressing `a` to show the all branches log, and even more so for people who use the "statusPanelView: allBranchesLog" config. And it doesn't really hurt for the dashboard view either, so just enable it always rather than making a distinction which view we are showing.
…n view title prefix We show it only if the "showPanelJumps" config is on, although the focus-main-view command is not technically part of the panel jump keys; but it looks similar.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
Comment on lines
+208
to
+213
| keyToTitlePrefix := func(key string) string { | ||
| if key == "<disabled>" { | ||
| return "" | ||
| } | ||
| return fmt.Sprintf("[%s]", key) | ||
| } |
There was a problem hiding this comment.
Fix display of panel jump keys for disabled bindings
- commit subject
hi!
this handles the corresponding in this section from config docs, right?
Lines 963 to 969 in 143d476
tab (or tabular space / tabulation) character is:
same goes for sentence-breaks in prose:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show the
[0]keybinding in the title of the main view, to make it more discoverable.Also, move it to the "global" section of the keybindings menu.
And several minor fixes and cleanups, see individual commits for details.
Fixes #4738.