Bump minimum required git version to 2.32 #4718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been requiring 2.22 for a while now.
stefanhaller
added
the
maintenance
The version choice is a little arbitrary, but see discussion at #4559 (comment). The main reason why I'm updating the version now is that versions before 2.27 had a bug with branch sorting, where sorting by -committerdate (which will be our default soon) would sort branches that point at the same commit in reverse alphabetical order rather than alphabetical order. While this is only slightly annoying but not a huge deal for users, it makes maintaining our integration tests across versions very hard. So I wanted to update to at least 2.27 to get around this problem, and went with 2.32 after the discussion linked to above. The choice of which versions to run integration tests on is pretty arbitrary too, I just picked some at random which are about 5 to 6 minor versions apart.
These only ran for git versions that we no longer support.
stefanhaller
force-pushed
the
bump-minimum-required-git-version
branch
from
e9962ea to
c739357
Compare
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
stefanhaller
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump minimum required git version to 2.32
The version choice is a little arbitrary, but see discussion at
#4559 (comment).
The main reason why I'm updating the version now is that versions before 2.27
had a bug with branch sorting, where sorting by -committerdate (which will be
our default soon) would sort branches that point at the same commit in reverse
alphabetical order rather than alphabetical order. While this is only slightly
annoying but not a huge deal for users, it makes maintaining our integration
tests across versions very hard. So I wanted to update to at least 2.27 to get
around this problem, and went with 2.32 after the discussion linked to above.
The choice of which versions to run integration tests on is pretty arbitrary
too, I just picked some at random which are about 5 to 6 minor versions apart.