Skip to content

Fix/loadbuffer status error and progress count #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix/loadbuffer status error and progress count #21

wants to merge 3 commits into from

Conversation

jasco
Copy link

@jasco jasco commented Jun 30, 2016

Addresses two issues found using loadBuffer

  1. When the audio data request failed, HTTP status errors were ignored and decodeAudioData was invoked with invalid data resulting
  2. On errors the inProgressCount parameter was updated after the call to the client's onError method making it more difficult for the client to determine whether all pending files had been loaded.

@jasco jasco force-pushed the fix/loadbuffer-status-error-and-progress-count branch from 384bd35 to 132c077 Compare June 30, 2016 14:32
@jasco jasco force-pushed the fix/loadbuffer-status-error-and-progress-count branch 3 times, most recently from 3bb45e8 to e32fb85 Compare June 30, 2016 16:26
@jasco jasco force-pushed the fix/loadbuffer-status-error-and-progress-count branch from e32fb85 to 2cf2738 Compare June 30, 2016 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jasco