Make dwarf_init_path_a
error non-fatal
#251
Open
+11
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an exception in the case of a "corrupted" ELF section (just unreadable by libdwarf, not corrupted). It turned out to be percolated from
dwarf_init_path_a
returning an error. libdwarf failing to parse an object should not inhibit falling back to parsing the ELF symtab, so I make this particular path less fatal.I repeated
ok = false;
for consistency and readability but I do realize all of the appearances in the function of this line seem redundant.