Replace jquery.timeentry with jquery-timepicker #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alindeman-NOAA
force-pushed
the
new-timepicker
branch
from
981db80 to
e1fb364
Compare
alindeman-NOAA
force-pushed
the
new-timepicker
branch
from
e1fb364 to
684ed80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the timepicker mentioned in #104.
I like it (e.g., it allows typing "1935" and will automatically format it as "19:35") but it does work differently from the current version as far as tabbing. I won't merge it until I have a chance to talk to @jeremiaheb about the differences, and to make sure they are OK to ship.
minTimeandmaxTimealso work differently. If we set them, "0500" will not format to "05:00" but it will otherwise validate if nothing is checking the format. Therefore I chose to punt the validation of the time range tojquery-validationinstead for a consistent experience and error message.