Skip to content

Conversation

SKroell
Copy link

@SKroell SKroell commented May 27, 2020

When using VERSION_SPEC as a build parameter, the plugin should checkout the files as of that version. To do this QueryHistory is called on the version_spec, and the first changeset is returned.
The issue here is that if the project path references has been changed in newer changesets, the QueryHistory method, will return those as well, so the Plugin returns not the wanted changeset as defined by VERSION_SPEC, but the newest available changeset where changes where made to the path/project.

This PR proposes to simply limit the upper range of the query to the versionspec. This makes it so that when we return the top element, it will at most be the wanted changeset. If the changeset does not exist it will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant