Added Label added trigger to plugin #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support to define a
labelAddedTrigger
(this is something we need to support), this could be generalized to any label event if it was required, but I feel like this is the most common usecase.Potentially this can be extended to support a regex instead of a list (I'm open to do that as it seems simple enough).This is now supported.Opening the PR early in order to get feedback and I know that there's a CI for PRs that generates artifacts, so i could easily test this out in our jenkins instance.
Should fix part of #72
but in order to fully fix it it'd need to support regexes.Testing done
Set it up locally on our jenkins server and added a trigger, with the following syntax:
and it worked.