Resolved mismatch stubbings in CompareCoverageActionTest.java #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I analyzed the test doubles (mocks) in the test code of the project. In my analysis of the project, I observed that
In tests
postCoverageStatusToPullRequestAsComment
,postResultAsStatusCheck
,postResultAsSuccessfulStatusCheck
,postResultAsFailedStatusCheck
,keepBuildGreenAndLogErrorIfExceptionDuringGitHubAccess
,postCoverageStatusToPullRequestAsCommentWithShieldIoIfPrivateJenkinsPublicGitHubTurnOn
andpostCoverageStatusToPullRequestAsCommentWithCustomJenkinsUrlIfConfigured
,get
method for theenvVars
object:i) is stubbed in the
prepareEnvVars
methodii) during test execution the method is actually called with argument
"CHANGE_ID"
, but is not stubbed, resulting in a mismatch stubbingiii) during test execution the method is actually called with argument
"CHANGE_URL"
, but is not stubbed, resulting in another mismatch stubbingIn general, a mismatched stubbing occurs when a method is stubbed with specific arguments in a test but later invoked with different arguments in the code. Mockito recommends addressing this type of issue (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org.mockito/org/mockito/exceptions/misusing/PotentialStubbingProblem.html).
I propose a solution below to resolve the mismatch stubbing. Happy to modify the pull request based on your feedback.
Submitter checklist