Change default behaviour of "Suppress progress updates in job check" #299
Conversation
|
Hi Tim, We are using GitHub Cloud, so we cannot disable the rate limit. Our controller is used by many different teams and they often share the same rate limit. If I am not mistaken, batching the calls would likely not help here, since the feature is about constant status updates on how far the build job is - if we batch those, they would be delayed and don't make any sense anymore anyways, if you understand what I mean. |
It depends on how often the updates currently are being sent. if they were grouped to send no more often than 1-2 minutes per job then that may alleviate it while still being fresh enough to being useful. |
|
Do you mean batching the calls from multiple jobs? Since it is currently already possible to disable the progress updates on a per-job level, it would be nice to have the feature of this PR to change the default value globally :) |
| public static final boolean defaultSkipProgressUpdates; | ||
| public static final boolean enforceSkipProgressUpdates; |
There was a problem hiding this comment.
these shouldn't be final / static, why do you need them in here? these will only get set on jenkins start
| <j:var set="readOnlyMode" value="${descriptor.enforceSkipProgressUpdates}" /> | ||
| <j:if test="${!readP}"> | ||
| <f:entry title="${%Suppress progress updates in job check}" field="skipProgressUpdates" | ||
| description="${%Queued, checkout and completed will still be sent}"> | ||
| <f:checkbox default="${descriptor.defaultSkipProgressUpdates}"/> | ||
| </f:entry> | ||
| </j:if> |
There was a problem hiding this comment.
We would need some advice on Jelly conditional rendering here.. we try to hide the option on the jobs, if the global configuration says that the option is enforced.
It seems like ${!readOnlyMode} does not resolve correctly here (we tried it with and without the descriptor). If you have any idea, let us know. Thanks!
| <j:var set="readOnlyMode" value="${descriptor.enforceSkipProgressUpdates}" /> | ||
| <j:if test="${!readP}"> |
There was a problem hiding this comment.
why not just do this?
| <j:var set="readOnlyMode" value="${descriptor.enforceSkipProgressUpdates}" /> | |
| <j:if test="${!readP}"> | |
| <j:if test="${!descriptor.enforceSkipProgressUpdates}"> |
There was a problem hiding this comment.
Same result. We built that complicated workaround because this did not work initially.
Change default behaviour of "Suppress progress updates in job check" to reduce GitHub API call because of the rate limit and add a global config for this setting.
We tried to enforce the the global setting but we need some advice about Jelly on this
thx to @meiswjn