Fix issue linking build status to unrelated PRs #905
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+28
to
+33
| class ChangeRequestCheckoutStrategy { | ||
|
|
||
| static Object HEAD; | ||
| static Object HEAD; | ||
|
|
||
| } |
There was a problem hiding this comment.
How can this pass tests?
There was a problem hiding this comment.
https://github.com/jenkinsci/bitbucket-branch-source-plugin/actions/runs/11724191362/job/32657525556?pr=905 shows multiple compilation errors:
[ERROR] /home/runner/work/bitbucket-branch-source-plugin/bitbucket-branch-source-plugin/src/test/java/com/cloudbees/jenkins/plugins/bitbucket/ChangeRequestCheckoutStrategy.java:[31,19] variable HEAD is already defined in class com.cloudbees.jenkins.plugins.bitbucket.ChangeRequestCheckoutStrategy
[ERROR] /home/runner/work/bitbucket-branch-source-plugin/bitbucket-branch-source-plugin/src/test/java/com/cloudbees/jenkins/plugins/bitbucket/MigrationTest.java:[5,36] package com.palantir.gradle.versions does not exist
[ERROR] /home/runner/work/bitbucket-branch-source-plugin/bitbucket-branch-source-plugin/src/test/java/com/cloudbees/jenkins/plugins/bitbucket/MigrationTest.java:[23,9] cannot find symbol
symbol: class FixLegacy
location: class com.cloudbees.jenkins.plugins.bitbucket.MigrationTest
[ERROR] /home/runner/work/bitbucket-branch-source-plugin/bitbucket-branch-source-plugin/src/test/java/com/cloudbees/jenkins/plugins/bitbucket/MigrationTest.java:[23,36] cannot find symbol
symbol: class FixLegacyJavaConfigurationsPlugin
location: class com.cloudbees.jenkins.plugins.bitbucket.MigrationTest
[ERROR] /home/runner/work/bitbucket-branch-source-plugin/bitbucket-branch-source-plugin/src/test/java/com/cloudbees/jenkins/plugins/bitbucket/MigrationTest.java:[31,47] cannot find symbol
symbol: class FixLegacyMigration1
location: class com.cloudbees.jenkins.plugins.bitbucket.MigrationTest
KalleOlaviNiemitalo
suggested changes
Nov 7, 2024
There was a problem hiding this comment.
This doesn't build, and even if it did, I don't believe it would fix #877.
|
It's not clear how these changes can solve the issues of unrelated build status to a pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request resolves Issue #877 in the Bitbucket Branch Source Plugin, where there was an issue with associating build statuses correctly with pull requests.
What I did:
Fixed Build Status Association: Adjusted the logic to ensure that build statuses are properly associated with the corresponding pull request, even in cases where multiple pull requests reference the same commit.
Improved Pull Request Handling: Enhanced the plugin’s ability to correctly associate build statuses with pull requests, ensuring accurate build notifications for users.
Testing:
Added relevant unit tests to ensure the correct mapping of build statuses to pull requests.
Performed tests in a Jenkins environment to confirm that the fix works as expected.