Move endpoint implementations to impl package #1058
Conversation
nfalco79
force-pushed
the
feature/move_endpoint_to_impl_package
branch
4 times, most recently
from
ade4e67 to
c2ffcef
Compare
| String hookReceiverURL = BitbucketEndpointProvider.lookupEndpointJenkinsRootURL(source.getServerUrl()) | ||
| + BitbucketSCMSourcePushHookReceiver.FULL_PATH; |
There was a problem hiding this comment.
This seems risky; lookupEndpointJenkinsRootURL might end up using DisplayURLProvider.get().getRoot() which might return the URL of an alternative root page provided by a plugin. Then the result of the concatenation might not resolve to a page.
There was a problem hiding this comment.
It should replicate the same behavour in abstractbitbucketendpoint
nfalco79
force-pushed
the
feature/move_endpoint_to_impl_package
branch
from
c2ffcef to
3f01369
Compare
| * @return the normalized custom or default Jenkins Root URL value | ||
| */ | ||
| @NonNull | ||
| public static String getEndpointJenkinsRootUrl(String serverURL) { |
There was a problem hiding this comment.
@KalleOlaviNiemitalo this was the old logic. It's the same of actual. If Jenkins endpoint URL has not been customised for this endpoint than it use the Jenkins default set in Manage Jenkins -> Jenkins Location -> Jenkins URL
nfalco79
force-pushed
the
feature/move_endpoint_to_impl_package
branch
3 times, most recently
from
446166c to
5b35640
Compare
nfalco79
force-pushed
the
feature/move_endpoint_to_impl_package
branch
from
5b35640 to
71e0245
Compare
|
Hi @nfalco79 ! Is there any chance we can get a new release of the plugin soon? Much appreciated! |
|
In a couple of weeks. The time the bom with blue ocean and actual bitbucket version are released un weekly bom and pr #1061 is completed |
No description provided.