Fix checkstyle issues

Author: nfalco79

pom.xml

@@ -5,7 +5,7 @@
   <parent>
     <groupId>org.jenkins-ci.plugins</groupId>
     <artifactId>plugin</artifactId>
-    <version>4.86</version>
+    <version>4.88</version>
     <relativePath />
   </parent>
 

src/main/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketSCMSource.java

@@ -88,7 +88,6 @@
 import java.util.logging.Logger;
 import jenkins.authentication.tokens.api.AuthenticationTokens;
 import jenkins.model.Jenkins;
-import jenkins.plugins.git.AbstractGitSCMSource.SCMRevisionImpl;
 import jenkins.plugins.git.traits.GitBrowserSCMSourceTrait;
 import jenkins.scm.api.SCMHead;
 import jenkins.scm.api.SCMHeadCategory;
@@ -999,44 +998,14 @@ private BitbucketCommit findPRDestinationCommit(BitbucketPullRequest pr, TaskLis
 
     @Override
     public SCM build(SCMHead head, SCMRevision revision) {
-        BitbucketRepositoryType type;
-        if (head instanceof PullRequestSCMHead) {
-            type = ((PullRequestSCMHead) head).getRepositoryType();
-        } else if (head instanceof BranchSCMHead) {
-            type = ((BranchSCMHead) head).getRepositoryType();
-        } else if (head instanceof BitbucketTagSCMHead) {
-            type = ((BitbucketTagSCMHead) head).getRepositoryType();
-        } else {
-            throw new IllegalArgumentException("Either PullRequestSCMHead, BitbucketTagSCMHead or BranchSCMHead required as parameter");
-        }
-        if (type == null) {
-            if (revision instanceof SCMRevisionImpl) {
-                type = BitbucketRepositoryType.GIT;
-            } else {
-                try {
-                    type = getRepositoryType();
-                } catch (IOException | InterruptedException e) {
-                    type = BitbucketRepositoryType.GIT;
-                    LOGGER.log(Level.SEVERE,
-                            "Could not determine repository type of " + getRepoOwner() + "/" + getRepository()
-                                    + " on " + getServerUrl() + " for " + getOwner() + " assuming " + type, e);
-                }
-            }
-        }
-        assert type != null;
         initCloneLinks();
 
-        switch (type) {
-            case GIT:
-            default:
-                BitbucketAuthenticator authenticator = authenticator();
-                return new BitbucketGitSCMBuilder(this, head, revision, null)
-                        .withExtension(authenticator == null ? null : new GitClientAuthenticatorExtension(authenticator.getCredentialsForScm()))
-                        .withCloneLinks(primaryCloneLinks, mirrorCloneLinks)
-                        .withTraits(traits)
-                        .build();
-
-        }
+        BitbucketAuthenticator authenticator = authenticator();
+        return new BitbucketGitSCMBuilder(this, head, revision, null)
+                .withExtension(authenticator == null ? null : new GitClientAuthenticatorExtension(authenticator.getCredentialsForScm()))
+                .withCloneLinks(primaryCloneLinks, mirrorCloneLinks)
+                .withTraits(traits)
+                .build();
     }
 
     private void setPrimaryCloneLinks(List<BitbucketHref> links) {

src/test/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketBuildStatusNotificationsTest.java

@@ -32,11 +32,11 @@
 import com.cloudbees.jenkins.plugins.bitbucket.endpoints.BitbucketCloudEndpoint;
 import com.cloudbees.jenkins.plugins.bitbucket.filesystem.BitbucketSCMFile;
 import hudson.model.Action;
+import hudson.model.Descriptor.FormException;
 import hudson.model.FreeStyleBuild;
 import hudson.model.FreeStyleProject;
 import hudson.model.Result;
 import hudson.model.TaskListener;
-import hudson.model.Descriptor.FormException;
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
 import java.net.URL;

src/test/java/com/cloudbees/jenkins/plugins/bitbucket/Security2033Test.java

@@ -11,7 +11,6 @@
 import hudson.security.ACLContext;
 import hudson.util.FormValidation;
 import hudson.util.ListBoxModel;
-import java.io.IOException;
 import java.net.HttpURLConnection;
 import jenkins.model.Jenkins;
 import org.hamcrest.CoreMatchers;

src/test/java/com/cloudbees/jenkins/plugins/bitbucket/endpoints/AbstractBitbucketEndpointDescriptorTest.java

@@ -32,7 +32,6 @@
 import com.cloudbees.plugins.credentials.impl.UsernamePasswordCredentialsImpl;
 import com.damnhandy.uri.template.UriTemplate;
 import edu.umd.cs.findbugs.annotations.NonNull;
-import hudson.model.Descriptor.FormException;
 import hudson.util.ListBoxModel;
 import java.util.Collections;
 import java.util.List;