Bump jenkins version to 2.462.3

Author: nfalco79

pom.xml

@@ -28,7 +28,7 @@
   <properties>
     <changelist>999999-SNAPSHOT</changelist>
     <gitHubRepo>jenkinsci/bitbucket-branch-source-plugin</gitHubRepo>
-    <jenkins.version>2.440.3</jenkins.version>
+    <jenkins.version>2.462.3</jenkins.version>
     <hpi.compatibleSinceVersion>2.0</hpi.compatibleSinceVersion>
     <useBeta>true</useBeta> <!-- Jenkins.MANAGE -->
   </properties>
@@ -63,8 +63,8 @@
     <dependencies>
       <dependency>
         <groupId>io.jenkins.tools.bom</groupId>
-        <artifactId>bom-2.440.x</artifactId>
-        <version>3221.ve8f7b_fdd149d</version>
+        <artifactId>bom-2.462.x</artifactId>
+        <version>3559.vb_5b_81183b_d23</version>
         <scope>import</scope>
         <type>pom</type>
       </dependency>

src/main/java/com/cloudbees/jenkins/plugins/bitbucket/api/credentials/BitbucketAccessTokenAuthenticator.java

@@ -4,6 +4,7 @@
 import com.cloudbees.plugins.credentials.CredentialsScope;
 import com.cloudbees.plugins.credentials.common.StandardUsernameCredentials;
 import com.cloudbees.plugins.credentials.impl.UsernamePasswordCredentialsImpl;
+import hudson.model.Descriptor.FormException;
 import hudson.util.Secret;
 import org.apache.commons.lang.StringUtils;
 import org.apache.http.HttpHeaders;
@@ -38,7 +39,11 @@ public void configureRequest(HttpRequest request) {
 
     @Override
     public StandardUsernameCredentials getCredentialsForScm() {
-        return new UsernamePasswordCredentialsImpl(
-                CredentialsScope.GLOBAL, null, null, StringUtils.EMPTY, token.getPlainText());
+        try {
+            return new UsernamePasswordCredentialsImpl(
+                    CredentialsScope.GLOBAL, null, null, StringUtils.EMPTY, token.getPlainText());
+        } catch (FormException e) {
+            throw new RuntimeException(e);
+        }
     }
 }

src/main/java/com/cloudbees/jenkins/plugins/bitbucket/api/credentials/BitbucketOAuthAuthenticator.java

@@ -5,6 +5,7 @@
 import com.cloudbees.plugins.credentials.common.StandardUsernameCredentials;
 import com.cloudbees.plugins.credentials.common.StandardUsernamePasswordCredentials;
 import com.cloudbees.plugins.credentials.impl.UsernamePasswordCredentialsImpl;
+import hudson.model.Descriptor.FormException;
 import org.apache.commons.lang.StringUtils;
 import org.apache.http.HttpRequest;
 import org.scribe.model.OAuthConfig;
@@ -40,7 +41,11 @@ public void configureRequest(HttpRequest request) {
 
     @Override
     public StandardUsernameCredentials getCredentialsForScm() {
-        return new UsernamePasswordCredentialsImpl(
-                CredentialsScope.GLOBAL, null, null, StringUtils.EMPTY, token.getToken());
+        try {
+            return new UsernamePasswordCredentialsImpl(
+                    CredentialsScope.GLOBAL, null, null, StringUtils.EMPTY, token.getToken());
+        } catch (FormException e) {
+            throw new RuntimeException(e);
+        }
     }
 }

src/main/java/com/cloudbees/jenkins/plugins/bitbucket/api/credentials/BitbucketUsernamePasswordAuthenticator.java

@@ -30,6 +30,7 @@
 import com.cloudbees.plugins.credentials.common.StandardUsernameCredentials;
 import com.cloudbees.plugins.credentials.common.StandardUsernamePasswordCredentials;
 import com.cloudbees.plugins.credentials.impl.UsernamePasswordCredentialsImpl;
+import hudson.model.Descriptor.FormException;
 import java.util.logging.Level;
 import java.util.logging.Logger;
 import org.apache.http.HttpHost;
@@ -80,7 +81,11 @@ public void configureContext(HttpClientContext context, HttpHost host) {
 
     @Override
     public StandardUsernameCredentials getCredentialsForScm() {
-        return new UsernamePasswordCredentialsImpl(
-                CredentialsScope.GLOBAL, null, null, httpCredentials.getUserName(), httpCredentials.getPassword());
+        try {
+            return new UsernamePasswordCredentialsImpl(
+                    CredentialsScope.GLOBAL, null, null, httpCredentials.getUserName(), httpCredentials.getPassword());
+        } catch (FormException e) {
+            throw new RuntimeException(e);
+        }
     }
 }

src/test/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketBuildStatusNotificationsTest.java

@@ -36,6 +36,7 @@
 import hudson.model.FreeStyleProject;
 import hudson.model.Result;
 import hudson.model.TaskListener;
+import hudson.model.Descriptor.FormException;
 import java.io.ByteArrayInputStream;
 import java.io.IOException;
 import java.net.URL;
@@ -183,7 +184,11 @@ public DummyWorkflowBranchProjectFactory(String dsl) {
 
         @Override
         protected FlowDefinition createDefinition() {
-            return new CpsFlowDefinition(dsl, true);
+            try {
+                return new CpsFlowDefinition(dsl, true);
+            } catch (FormException e) {
+                throw new RuntimeException(e);
+            }
         }
 
         @Override

src/test/java/com/cloudbees/jenkins/plugins/bitbucket/BitbucketGitSCMBuilderTest.java

@@ -56,7 +56,7 @@ public class BitbucketGitSCMBuilderTest {
     private WorkflowMultiBranchProject owner;
 
     @Before
-    public void setUp() throws IOException {
+    public void setUp() throws Exception {
         owner = j.createProject(WorkflowMultiBranchProject.class);
         source = new BitbucketSCMSource( "tester", "test-repo");
         owner.setSourcesList(Collections.singletonList(new BranchSource(source)));

src/test/java/com/cloudbees/jenkins/plugins/bitbucket/Security2033Test.java

@@ -163,7 +163,7 @@ public void doClearWhenInvokedUsingGetMethodThenResourceNotFound() throws Except
         assertThat(page.getWebResponse().getContentAsString(), containsString("Stapler processed this HTTP request as follows, but couldn't find the resource to consume the request"));
     }
 
-    private void initCredentials() throws IOException {
+    private void initCredentials() throws Exception {
         StandardUsernamePasswordCredentials key = new UsernamePasswordCredentialsImpl(CredentialsScope.GLOBAL, "id", "desc", "username", "pass");
         SystemCredentialsProvider.getInstance().getCredentials().add(key);
 

src/test/java/com/cloudbees/jenkins/plugins/bitbucket/endpoints/AbstractBitbucketEndpointDescriptorTest.java

@@ -32,6 +32,7 @@
 import com.cloudbees.plugins.credentials.impl.UsernamePasswordCredentialsImpl;
 import com.damnhandy.uri.template.UriTemplate;
 import edu.umd.cs.findbugs.annotations.NonNull;
+import hudson.model.Descriptor.FormException;
 import hudson.util.ListBoxModel;
 import java.util.Collections;
 import java.util.List;
@@ -56,7 +57,7 @@ public void reset() {
     }
 
     @Test
-    public void given__cloudCredentials__when__listingForServer__then__noCredentials() {
+    public void given__cloudCredentials__when__listingForServer__then__noCredentials() throws Exception {
         SystemCredentialsProvider.getInstance().setDomainCredentialsMap(Collections.singletonMap(
                 new Domain("cloud", "bb cloud",
                         Collections.<DomainSpecification>singletonList(new HostnameSpecification("bitbucket.org", ""))),
@@ -68,7 +69,7 @@ public void given__cloudCredentials__when__listingForServer__then__noCredentials
     }
 
     @Test
-    public void given__cloudCredentials__when__listingForCloud__then__credentials() {
+    public void given__cloudCredentials__when__listingForCloud__then__credentials() throws Exception {
         SystemCredentialsProvider.getInstance().setDomainCredentialsMap(Collections.singletonMap(
                 new Domain("cloud", "bb cloud",
                         Collections.<DomainSpecification>singletonList(new HostnameSpecification("bitbucket.org", ""))),

src/test/java/com/cloudbees/jenkins/plugins/bitbucket/endpoints/AbstractBitbucketEndpointTest.java

@@ -79,15 +79,15 @@ public void given__manage_true__when__credentials__then__credentialsSet() {
     }
 
     @Test
-    public void given__mange__when__systemCredentials__then__credentialsFound() {
+    public void given__mange__when__systemCredentials__then__credentialsFound() throws Exception {
         SystemCredentialsProvider.getInstance().setDomainCredentialsMap(Collections.singletonMap(Domain.global(),
                 Collections.<Credentials>singletonList(new UsernamePasswordCredentialsImpl(
                         CredentialsScope.SYSTEM, "dummy", "dummy", "user", "pass"))));
         assertThat(new Dummy(true, "dummy").credentials(), notNullValue());
     }
 
     @Test
-    public void given__mange__when__globalCredentials__then__credentialsFound() {
+    public void given__mange__when__globalCredentials__then__credentialsFound() throws Exception {
         SystemCredentialsProvider.getInstance().setDomainCredentialsMap(Collections.singletonMap(Domain.global(),
                 Collections.<Credentials>singletonList(new UsernamePasswordCredentialsImpl(
                         CredentialsScope.GLOBAL, "dummy", "dummy", "user", "pass"))));