-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add button to adjust audio playback rate #7281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,6 +4,7 @@ | |||||||||
| import { getItemTextLines } from 'apps/stable/features/playback/utils/itemText'; | ||||||||||
| import { AppFeature } from 'constants/appFeature'; | ||||||||||
|
|
||||||||||
| import actionsheet from '../actionSheet/actionSheet'; | ||||||||||
| import datetime from '../../scripts/datetime'; | ||||||||||
| import { clearBackdrop, setBackdrops } from '../backdrop/backdrop'; | ||||||||||
| import listView from '../listview/listview'; | ||||||||||
|
|
@@ -47,7 +48,7 @@ | |||||||||
| return menuItem; | ||||||||||
| }); | ||||||||||
|
|
||||||||||
| import('../actionSheet/actionSheet').then((actionsheet) => { | ||||||||||
| actionsheet.show({ | ||||||||||
| items: menuItems, | ||||||||||
| positionTo: button, | ||||||||||
|
|
@@ -79,7 +80,7 @@ | |||||||||
| selected: currentIndex == null | ||||||||||
| }); | ||||||||||
|
|
||||||||||
| import('../actionSheet/actionSheet').then((actionsheet) => { | ||||||||||
| actionsheet.show({ | ||||||||||
| items: menuItems, | ||||||||||
| positionTo: button, | ||||||||||
|
|
@@ -829,6 +830,29 @@ | |||||||||
| } | ||||||||||
| } | ||||||||||
| }); | ||||||||||
|
|
||||||||||
| let showPlaybackRateMenuButton = context.querySelector('.showPlaybackRateMenuButton') | ||||||||||
|
Check failure on line 834 in src/components/remotecontrol/remotecontrol.js
|
||||||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 'showPlaybackRateMenuButton' is never reassigned. Use 'const' instead. prefer-const Fix available:
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Missing semicolon. @stylistic/semi Fix available:
Suggested change
|
||||||||||
| showPlaybackRateMenuButton.addEventListener('click', function () { | ||||||||||
| // each has a name and id | ||||||||||
| const currentId = playbackManager.getPlaybackRate(currentPlayer); | ||||||||||
| const menuItems = playbackManager.getSupportedPlaybackRates(currentPlayer).map(i => ({ | ||||||||||
| id: i.id, | ||||||||||
| name: i.name, | ||||||||||
| selected: i.id === currentId | ||||||||||
| })); | ||||||||||
|
|
||||||||||
| return actionsheet.show({ | ||||||||||
| items: menuItems, | ||||||||||
| positionTo: showPlaybackRateMenuButton, | ||||||||||
| }).then(function (id) { | ||||||||||
|
||||||||||
| positionTo: showPlaybackRateMenuButton, | |
| }).then(function (id) { | |
| positionTo: showPlaybackRateMenuButton | |
| }).then(function (id) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unexpected trailing comma. @stylistic/comma-dangle
Fix available: