Support UUIDs as tenant ids

[anka]

When using UUIDs as your ActiveRecord model ids the current implementation was not able to handle them. Especially some code required an Integer as tenant id. These restriction were remove and replaced by the method Milia::Support. valid_tenant_id?. Also the method where_restrict_tenant was updated to handle strings within the generated where clause.

[dsaronin]

I don't recommend removing the status log output.. there should be a switch paramter to reduce it, or else change the LOG state. It really is critical for debugging devise issues..

…

On Tue, Jun 13, 2017 at 8:22 AM Andreas ***@***.***> wrote: When using UUIDs as your ActiveRecord model ids the current implementation was not able to handle them. Especially some code required an Integer as tenant id. These restriction were remove and replaced by the method Milia::Support. valid_tenant_id?. Also the method where_restrict_tenant was updated to handle strings within the generated where clause. ------------------------------ You can view, comment on, or merge this pull request online at: #73 Commit Summary - Allow strings as tenant_ids to support UUIDs - Update `where_restrict_tenant` to support string ids - Remove unnecessary debug output - Replace Gemfile.lock with origninal content File Changes - *M* lib/milia.rb <https://github.com/jekuno/milia/pull/73/files#diff-0> (1) - *M* lib/milia/base.rb <https://github.com/jekuno/milia/pull/73/files#diff-1> (12) - *A* lib/milia/support.rb <https://github.com/jekuno/milia/pull/73/files#diff-2> (14) - *M* test/Gemfile.lock <https://github.com/jekuno/milia/pull/73/files#diff-3> (4) - *M* test/test/fixtures/tenants.yml <https://github.com/jekuno/milia/pull/73/files#diff-4> (4) - *M* test/test/models/tenant_test.rb <https://github.com/jekuno/milia/pull/73/files#diff-5> (15) - *M* test/test/models/user_test.rb <https://github.com/jekuno/milia/pull/73/files#diff-6> (2) Patch Links: - https://github.com/jekuno/milia/pull/73.patch - https://github.com/jekuno/milia/pull/73.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#73>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAZDDI-M3YG0hfHZMxS_-YIB4O5VCqopks5sDqkegaJpZM4N4p8K> .

[anka]

I think you are referencing my commit message Remove unnecessary debug output. I am sorry for that if it is misleading, but actually I did only remove some debug output of my own code I used to test the feature. All other log output remains as it was.

[dasibre]

Anyway I can be of assistance in getting this pull request merged and up and running?

[anka]

I would appreciate it if @jekuno would merge this pull request too.