refactor: merge changes from master branch to v3 #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cept: application/json` header (jeertmans#129) * fix query to form encoded payload * change all requests to form encoded * add accept header "application/json" * revert /words to query encoded * update changelog
* rename unrelease * prepare next unreleased section * add release process and changelog update * add cargo release install cmd * omit workspace
* fix doc * update changelog * apply review comments - clarified purpose of cargo release - simplified release preparation (removed parameters are in Cargo.toml) * Update RELEASE-PROCESS.md --------- Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
Rolv-Apneseth
force-pushed
the
rebase-v3
branch
from
8c1eb80 to
17a397d
Compare
CodSpeed Performance ReportMerging #135 will not alter performanceComparing Summary
|
|
Had to fix an import too. Otherwise seems OK. @jeertmans we should probably merge this one before #134, when you get the chance to review |
jeertmans
approved these changes
Mar 11, 2025
There was a problem hiding this comment.
Looks great, thanks @Rolv-Apneseth! Don't know why the date was removed in main, probably missed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase was freaking out for some reason so I went with a merge. Hopefully this carries over the changes correctly.
I had to manually edit the changelog but let me know if it's wrong. Do you use something for generating it? I saw
git-clifflisted at the bottom but for me the output is different.