fix(lib): use .form instead of .query when relevant and added Accept: application/json header
#129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Feb 21, 2025
jeertmans
reviewed
Feb 21, 2025
jeertmans
requested changes
Feb 21, 2025
There was a problem hiding this comment.
Hi @okaerin, thanks for your PR!
In my opinion, it looks great! I only made one suggestion, see the comment from @ccoVeille.
Other than that, could you please edit the CHANGELOG.md file to include a section about this fix?
jeertmans
changed the title
.form instead of .query when relevant and added Accept: application/json header
CodSpeed Performance ReportMerging #129 will improve performances by 24.95%Comparing Summary
Benchmarks breakdown
|
|
Looks great, thanks @okaerin! |
jeertmans
approved these changes
Feb 21, 2025
4 tasks
jeertmans
added a commit
that referenced
this pull request
Mar 11, 2025
* fix(lib): use `.form` instead of `.query` when relevant and added `Accept: application/json` header (#129) * fix query to form encoded payload * change all requests to form encoded * add accept header "application/json" * revert /words to query encoded * update changelog * chore(ci): add cargo release functionality (#130) * rename unrelease * prepare next unreleased section * add release process and changelog update * add cargo release install cmd * omit workspace * fix(docs): release process doc (#133) * fix doc * update changelog * apply review comments - clarified purpose of cargo release - simplified release preparation (removed parameters are in Cargo.toml) * Update RELEASE-PROCESS.md --------- Co-authored-by: Jérome Eertmans <jeertmans@icloud.com> * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Andreas Huber <43344129+okaerin@users.noreply.github.com> Co-authored-by: Jérome Eertmans <jeertmans@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #128
Description
Change to use the
formmethod instead ofqueryCheck List (Check all the applicable boxes)
Screenshots
Note to reviewers