-
Notifications
You must be signed in to change notification settings - Fork 103
Fix annotations support on 3.14 #852
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JelleZijlstra
wants to merge
1
commit into
jcrist:main
Choose a base branch
from
JelleZijlstra:314-annos
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
# type: ignore | ||
import collections | ||
import inspect | ||
import sys | ||
import typing | ||
|
||
|
@@ -71,6 +72,13 @@ def _eval_type(t, globalns, localns): | |
_eval_type = typing._eval_type | ||
|
||
|
||
if sys.version_info >= (3, 10): | ||
from inspect import get_annotations as _get_class_annotations | ||
else: | ||
def _get_class_annotations(cls): | ||
return cls.__dict__.get("__annotations__", {}) | ||
|
||
|
||
def _apply_params(obj, mapping): | ||
if isinstance(obj, typing.TypeVar): | ||
return mapping.get(obj, obj) | ||
|
@@ -149,17 +157,17 @@ def get_class_annotations(obj): | |
cls_locals = dict(vars(cls)) | ||
cls_globals = getattr(sys.modules.get(cls.__module__, None), "__dict__", {}) | ||
|
||
ann = cls.__dict__.get("__annotations__", {}) | ||
ann = _get_class_annotations(cls) | ||
for name, value in ann.items(): | ||
if name in hints: | ||
continue | ||
if value is None: | ||
value = type(None) | ||
elif isinstance(value, str): | ||
if isinstance(value, str): | ||
value = _forward_ref(value) | ||
value = _eval_type(value, cls_locals, cls_globals) | ||
if mapping is not None: | ||
value = _apply_params(value, mapping) | ||
if value is None: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed |
||
value = type(None) | ||
hints[name] = value | ||
return hints | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the portable approach, which should continue to work on future Python versions. If you value performance over portability, you can instead inline this function https://github.com/python/cpython/blob/9ddc7c548d45b73c84131e6d75b03c26a3e8b6e8/Lib/annotationlib.py#L824 ; it's just dict operations.
I made it a separate function in CPython so that we can be free to optimize the internal representation of annotate functions in the future. For example, perhaps in 3.15 the class will store just a code object instead of a function.