Update pil_engine.py #779
Open
Update pil_engine.py #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checking for image_info remove icc_profile if it fails to generate an image get raw_data even if there was an initial exception
for more information, see https://pre-commit.ci
|
Thanks! Do you think you would be able to provide a regression test? |
|
i dunno, i guess i can look how you write tests and use the image that was breaking for me. The image might not be one i can share here though, I'll have to ask |
|
Indeed, the idea is to have the smallest possible image that could be used to reproduced the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checking for image_info before looking for a key in it
remove icc_profile if it fails to generate an image
get raw_data even if there was an initial exception