Skip to content

Fix: Add mypy to pre-commit #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Fix: Add mypy to pre-commit #924

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aaac7c7
Fix: Add missing newline to .pre-commit-config.yaml
Tosinibikunle Aug 6, 2025
76e89e4
mypy.ini modified
Tosinibikunle Aug 6, 2025
f4f79fe
fixing pre-commit configuration
Tosinibikunle Aug 6, 2025
54d8370
Error resolution for mypy configuration
Tosinibikunle Aug 7, 2025
9739119
explicit packages mod
Tosinibikunle Aug 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ jobs:
- name: Tox tests
run: |
tox -v
- name: Run mypy
run: |
pip install mypy==1.17.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why install a specific mypy version?

mypy rest_framework_simplejwt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be checking the tests folder


env:
DJANGO: ${{ matrix.django-version }}
DRF: ${{ matrix.drf-version }}
Expand Down
6 changes: 6 additions & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,9 @@ repos:
- id: rst-linter
files: >-
^[^/]+[.]rst$
- repo: https://github.com/pre-commit/mirrors-mypy
rev: v1.17.1
hooks:
- id: mypy
args: ["rest_framework_simplejwt"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here


6 changes: 6 additions & 0 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[mypy]
python_version = 3.9
ignore_missing_imports = True
disallow_untyped_defs = True
check_untyped_defs = True
ignore_errors = True