Skip to content

docs: Add warning in docs for for_user usage #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

docs: Add warning in docs for for_user usage #872

merged 1 commit into from
Feb 27, 2025

Conversation

vgrozdanic
Copy link
Contributor

@vgrozdanic vgrozdanic commented Feb 26, 2025 •
edited
Loading

Adds a warning that for_user method is not validating if user is active, and adds a check if user is active in a code example in the docs.

Part of #779

@vgrozdanic vgrozdanic requested a review from a team February 26, 2025 22:02
Andrew-Chen-Wang
Andrew-Chen-Wang approved these changes Feb 27, 2025
View reviewed changes
Copy link
Member

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great thank you!

@Andrew-Chen-Wang Andrew-Chen-Wang mentioned this pull request Feb 27, 2025
Open
@vgrozdanic vgrozdanic merged commit 1ad763b into master Feb 27, 2025
21 checks passed
@vgrozdanic vgrozdanic deleted the vgrozdanic/update-docs-for-for-user branch February 27, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrew-Chen-Wang Andrew-Chen-Wang Andrew-Chen-Wang approved these changes

Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vgrozdanic @Andrew-Chen-Wang