Skip to content

add response message when token black listed. #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add response message when token black listed. #800

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc6c39b
add response message when token black listed.
amirdjango Apr 21, 2024
2da70b0
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 21, 2024
1dd152a
fix mistake adding key of message
amirdjango Apr 22, 2024
67ecae6
Merge remote-tracking branch 'origin/add-return-message-in-blacklist-…
amirdjango Apr 22, 2024
12c31c6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rest_framework_simplejwt/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,5 +116,11 @@ class TokenBlacklistView(TokenViewBase):

_serializer_class = api_settings.TOKEN_BLACKLIST_SERIALIZER

def post(self, request: Request, *args, **kwargs) -> Response:
response = super().post(request, *args, **kwargs)
serializer_data = response.data
serializer_data['Token detail'] = 'Token blacklisted'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to match a descriptive message such as that in the test, Token detail should be message.

Can you send in a fix?

serializer_data['message'] = 'Token blacklisted'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for your attention, sure as soon as possible


return Response(serializer_data, status=response.status_code)

token_blacklist = TokenBlacklistView.as_view()
2 changes: 1 addition & 1 deletion tests/test_serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ def test_it_should_return_nothing_if_everything_ok(self):
fake_aware_utcnow.return_value = now
self.assertTrue(s.is_valid())

self.assertDictEqual(s.validated_data, {})
self.assertDictEqual(s.validated_data, {"message": "Token blacklisted"})

def test_it_should_blacklist_refresh_token_if_everything_ok(self):
self.assertEqual(OutstandingToken.objects.count(), 0)
Expand Down