Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions project/tests/test_config_override.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
from django.test import TestCase, override_settings

from silk.config import SilkyConfig


class TestOverrideSettings(TestCase):
def test_respects_override_settings(self):
with override_settings(SILKY_INTERCEPT_PERCENT=0):
self.assertEqual(SilkyConfig().SILKY_INTERCEPT_PERCENT, 0)
7 changes: 7 additions & 0 deletions silk/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,13 @@ class SilkyConfig(metaclass=Singleton):

def _setup(self):
from django.conf import settings
from django.core.signals import setting_changed

options = {option: getattr(settings, option) for option in dir(settings) if option.startswith('SILKY')}
self.attrs = copy(self.defaults)
self.attrs['SILKY_PYTHON_PROFILER_RESULT_PATH'] = settings.MEDIA_ROOT
self.attrs.update(options)
setting_changed.connect(self._on_setting_changed)

def __init__(self):
super().__init__()
Expand All @@ -54,3 +56,8 @@ def __getattr__(self, item):

def __setattribute__(self, key, value):
self.attrs[key] = value

def _on_setting_changed(self, sender, **kwargs):
setting = kwargs.get('setting')
if setting and setting.startswith('SILKY'):
self.attrs[setting] = kwargs.get('value')
Loading