Support original_response in AXES_LOCKOUT_CALLABLE (with backward compatibility) #1347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR extends the
AXES_LOCKOUT_CALLABLE
setting to support an additionaloriginal_response
argument. This allows developers to customize lockout behavior more flexibly while maintaining backward compatibility with the previous two-argument signature.Code changes
get_lockout_response
now attempts to call the lockout callable with(request, original_response, credentials)
and falls back to(request, credentials)
if the callable does not accept the new parameter.original_response
.Documentation
Tests
original_response
.Motivation and context
The extra
original_response
parameter makes it possible to reuse or extend the existing lockout response instead of replacing it entirely. For example, one might still return the default login response but also trigger a message viadjango.contrib.messages
, or apply custom headers.Example usage:
Before submitting