Changes #36
Closed
Changes #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will close this now to not spam! |
jayaddison
reviewed
Jan 16, 2025
| return click.option(*param_decls, **kwargs) | ||
|
|
||
|
|
||
| ARG_API_KEY = click.argument("api_key", envvar="WISE_API_KEY", required=True) |
There was a problem hiding this comment.
@niccokunzmann I like the utility of having a CLI interface for various actions; and reading variables from env variables seems better than, for example, placing them on the commandline, for various reasons... however: environment variables don't seem ideal for long-lived credentials. Maybe there are alternatives here?
There was a problem hiding this comment.
As an alternative, one could use the Bitwarden secrets manager...
There was a problem hiding this comment.
What do some other transfer-capable payment client libraries do?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added a few changes and was able to transfer money to myself.
I have opened #31 and #33. The question for me is how we can collaborate. Maybe, it will just take time to figure out how we actually do this. I am grateful for the base you provided for my work. I also value your feedback.
What I did in these changes is use pydantic because
I really like the changes you make upstream, so I will merge them into my repo.
I wonder how you feel about those I made. We also seem to have different approaches (CI, minimality).
Greetings!