Skip to content

Added integration tests #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2024
Merged

Added integration tests #95

merged 2 commits into from
May 22, 2024

Conversation

surajkumar
Copy link
Contributor

@surajkumar surajkumar commented May 12, 2024

Describe the PR

  • Fixed some issues found during unit testing
  • Add a helper to test against the live discord API
  • Removed old imposter tests because they did not fit the requirement for actually testing our integration with discord
  • Added UserRequest tests
  • Added InviteRequest tests
  • Added VoiceRequest tests

Context:
We use the real discord API because even with all our mocking, it wouldn't actually serve for a valid integration tests. Therefore, Imposter is good for testing that we're decoding properly but not really sending the correct information to Discord or Discord is correctly handling our requests.

@surajkumar surajkumar force-pushed the user-request-unit-tests branch 2 times, most recently from ed93e70 to d5182da Compare May 12, 2024 13:42
@surajkumar surajkumar changed the title Unit tests for UserRequest Added integration tests May 22, 2024
@surajkumar surajkumar force-pushed the user-request-unit-tests branch from 2d53cb7 to a620ee4 Compare May 22, 2024 13:56
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@surajkumar surajkumar marked this pull request as ready for review May 22, 2024 14:07
@surajkumar surajkumar requested review from Taz03 and a team and removed request for Taz03 May 22, 2024 14:07
@surajkumar surajkumar merged commit 93d6ecc into main May 22, 2024
4 checks passed
@surajkumar surajkumar deleted the user-request-unit-tests branch May 22, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants