81 implement guild template api #90
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notyourhabibti
force-pushed
the
81-Implement-Guild-Template-API
branch
from
85c29bf to
ea7091e
Compare
surajkumar
previously approved these changes
May 5, 2024
Taz03
requested changes
May 5, 2024
...ain/java/com/javadiscord/jdi/internal/api/guild_template/CreateGuildFromTemplateRequest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/javadiscord/jdi/internal/api/guild_template/DeleteGuildTemplateRequest.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/javadiscord/jdi/internal/api/guild_template/DeleteGuildTemplate.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/javadiscord/jdi/internal/api/guild_template/DeleteGuildTemplateRequest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/com/javadiscord/jdi/internal/api/guild_template/CreateGuildTemplateRequest.java
Outdated
Show resolved
Hide resolved
notyourhabibti
force-pushed
the
81-Implement-Guild-Template-API
branch
from
7420dcc to
d46a8a4
Compare
surajkumar
approved these changes
May 5, 2024
Taz03
requested changes
May 6, 2024
| @@ -31,7 +31,6 @@ public DiscordRequestBuilder create() { | |||
| // entityMetadata (entity_metadata), scheduledEndTime are all required | |||
| if (entityType.isPresent() && entityType.get() == 3) { | |||
| if (entityMetadata.isEmpty() || scheduledEndTime.isEmpty()) { | |||
| // TODO: replace with custom exceptions when implemented | |||
Comment on lines
-10
to
-11
| // TODO: finish implementation | ||
| // https://discord.com/developers/docs/resources/guild#integration-object |
|
|
Closed in favour of #122 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests introduces the guild template API.
closes #81